stdenv/check-meta: add a warning for maintainerless derivations#170992
stdenv/check-meta: add a warning for maintainerless derivations#170992Mindavi merged 3 commits intoNixOS:masterfrom
Conversation
e4a9104 to
569ace0
Compare
|
I don't know... this approach feels too annoying. Just look at the |
|
Maybe in some far-away future when the |
|
Maybe instead we could add some easy way that allows you to enable this if you want. So you can easily check your own derivations. Dont know how to do this exactly though |
569ace0 to
38377dd
Compare
I've now gated this behind a new
Well, if we want to get closer to addressing the considerable amount of orphans we need something like this.
Strawman? Addressing everything in one PR is not feasible. |
|
(@roberth) Would you be open to a PR that documents all the other missing options I can think of, or is that already in the works? |
6169ee7 to
3c60f1e
Compare
|
@ckiee I don't really have time for "big" projects, so that would be very much appreciated. |
|
i'll add allowUnfree there EDIT: #171248 |
|
Turning that on right now. |
3c60f1e to
ea4951f
Compare
There was a problem hiding this comment.
Not sure about the valid changes mixed in here. But the warning for missing maintainers sounds like it could be useful for people interested in that. Personally I'm not looking forward to a wall of warnings, but I guess others may be.
Please at least split the valid change into a different commit, and reconsider making a separate PR for it.
ea4951f to
a48f638
Compare
I'm afraid you're a bit late for a separate PR (note how far this one has gone already) but I have split it into three commits with nicer, more detailed commit messages. Also I just noticed there's merge conflicts again, on that. |
This will allow for adding more validity types in the future, such as a warning type. (which is in the next commit in this series) This is NOT a breaking change because validity.valid is never exposed outside of `stdenv.mkDerivation`.
This will be used in the next commit in this patch series.
This warning logs when a package has no maintainers. It will stay silent if `meta.maintainers` is not set at all, only complaining when it is an empty list. In the future a separate warning could be added to allow for that stricter behavior. Or this warning could be changed.
a48f638 to
4def222
Compare
|
Good enough for me, thanks ✨ : |
|
@Mindavi Merge after Ofborg's happy? |
Description of changes
This makes stdenv.mkDerivation emit warnings when a package does not
have any maintainers in order to encourage these core packages to be adopted.
Evaluating
pkgs.hellocurrently results in 12 warnings, demonstratingthe need for this.
This behavior is gated behind a
showDerivationWarningsnixpkgs config optionto reduce unnecessary output for end users.
Example output:
cc @lheckemann, thanks for the idea.
TODO
Figure out why a warning forNot block-worthypython3-minimal-3.9.12is emitted even though it does have a maintainer